Backport of Add generic experiments configuration and use it to enable catalog v2 resources into release/1.16.x#17655
Merged
hc-github-team-consul-core merged 2 commits intoJun 12, 2023
Conversation
8bf7391 to
54f7681
Compare
77fd376 to
14cf0bb
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 12, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
mkeeler
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17604 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
We wanted the next gen catalog as resources feature to be disabled by default for now with the option to enable it. I could have added another boolean flag to enable like we have done for some other features but instead decided to rip off of vault and add an
experimentsconfig setting.The advantages of this approach are:
Testing & Reproduction steps
catalog-resourcesexperiment by defaultexperiments = ["catalog-resources"]- this enables the experimentPR Checklist
Overview of commits