Backport of OSS merge: Update error handling login when applying extensions into release/1.16.x#17742
Merged
hc-github-team-consul-core merged 1 commit intoJun 14, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/cthain/fix-extension-error-handling/indirectly-inviting-tetra
branch
from
8e250b2 to
1c79868
Compare
hc-github-team-consul-core
force-pushed
the
backport/cthain/fix-extension-error-handling/indirectly-inviting-tetra
branch
from
f323d50 to
9132463
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 14, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
hc-github-team-consul-core
deleted the
backport/cthain/fix-extension-error-handling/indirectly-inviting-tetra
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17740 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
This PR updates the logging and error handling logic for when extensions succeed or fail to apply. The existing behavior was always logging a failure message even when the extension was successfully applied. In some of the failure cases, the log message did not include the error returned from the extension.
Testing & Reproduction steps
agent/xdsunit tests.Links
PR Checklist
external facing docs updatedN/aOverview of commits