Skip to content

Backport of Improve Prop Override docs examples into release/1.16.x#17811

Merged
hc-github-team-consul-core merged 1 commit into
release/1.16.xfrom
backport/zalimeni/net-4403-prop-override-improve-docs-example/moderately-glorious-flounder
Jun 20, 2023
Merged

Backport of Improve Prop Override docs examples into release/1.16.x#17811
hc-github-team-consul-core merged 1 commit into
release/1.16.xfrom
backport/zalimeni/net-4403-prop-override-improve-docs-example/moderately-glorious-flounder

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #17799 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

  • Provide more realistics examples for setting properties not already
    supported natively by Consul
  • Remove superfluous commas from HCL, correct target service name, and
    fix service defaults vs. proxy defaults in examples
  • Align existing integration test to updated docs

Links

Existing docs: https://developer.hashicorp.com/consul/docs/v1.16.x/connect/proxies/envoy-extensions/usage/property-override

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner June 20, 2023 14:00
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/net-4403-prop-override-improve-docs-example/moderately-glorious-flounder branch from 9eae633 to ae1915e Compare June 20, 2023 14:00
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) June 20, 2023 14:00
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions Bot added the type/docs Documentation needs to be created/updated/clarified label Jun 20, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit 859baad into release/1.16.x Jun 20, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/net-4403-prop-override-improve-docs-example/moderately-glorious-flounder branch June 20, 2023 14:17
zalimeni added a commit that referenced this pull request Jun 21, 2023
zalimeni added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants