Backport of api-gateway: add step to upgrade instructions for creating intentions into release/1.16.x#17883
Merged
hc-github-team-consul-core merged 1 commit intoJun 26, 2023
Conversation
5c71d7e to
3f58449
Compare
6b63e19 to
cbff381
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 26, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
nathancoleman
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17875 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
The upgrade docs for migrating to the new native api-gateway solution should include a step for creating intentions that allow the gateway to communicate with the backend services that it’s routing to. This is important if a user does not have allow-all in place since the Gateway would be unable to communicate with the service backends post-upgrade.
In the legacy api-gateway solution, we created these intentions automatically; however, we intentionally stopped doing this with our new implementation.
Testing & Reproduction steps
Follow upgrade instructions.
Links
https://consul-asgedpqp3-hashicorp.vercel.app/consul/docs/api-gateway/upgrades#upgrade-to-native-consul-api-gateway
PR Checklist
Overview of commits