Backport of Fix bug with Vault CA provider into release/1.16.x#18161
Merged
hc-github-team-consul-core merged 3 commits intoJul 17, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/kisunji/NET-4766-vault-ca-bug-fix/precisely-trusted-bat
branch
2 times, most recently
from
008d297 to
cb6612a
Compare
hc-github-team-consul-core
force-pushed
the
backport/kisunji/NET-4766-vault-ca-bug-fix/precisely-trusted-bat
branch
from
8b0e9d8 to
f4a1a78
Compare
github-team-consul-core-pr-approver
approved these changes
Jul 17, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
Bot
added
the
theme/connect
hc-github-team-consul-core
deleted the
backport/kisunji/NET-4766-vault-ca-bug-fix/precisely-trusted-bat
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18112 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Background for reviewers
Vault can be used as a CA for Consul service mesh (docs). Typically an organization's root trust CA is stored as a root mount (configured by
RootPKIPath) in Vault. Consul uses an intermediate CA (stored inIntermediatePKIPath) signed by the root to issue leaf certificates to agents and services in the mesh.Description
Updating RootPKIPath but not IntermediatePKIPath would not update leaf signing certs with the new root. Unsure if this happens in practice but manual testing showed it is a bug that would break mesh and agent connections once the old root is pruned.
Testing & Reproduction steps
Added a unit test case updating RootPKIPath and not IntermediatePKIPath
Manually tested with a local cluster to ensure updating RootPKIPath did not break mesh communication.
PR Checklist
Overview of commits