Backport of test: fix snapshot save w/ append test for ENT into release/1.16.x#18659
Closed
hc-github-team-consul-core wants to merge 1 commit into
Closed
Conversation
hc-github-team-consul-core
force-pushed
the
backport/dans/fix-snapshot-save-test/willingly-golden-leopard
branch
from
255a3c1 to
99bb3d0
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Sep 1, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
asheshvidyut
requested review from
asheshvidyut
and removed request for
DanStough
asheshvidyut
approved these changes
Sep 4, 2023
…to release/1.16.x (#18520) resolve conflict Co-authored-by: temp <temp@hashicorp.com> Backport of bug: prevent go routine leakage due to existing DeferCheck into release/1.16.x (#18565) * backport of commit 06d4c72 * backport of commit 42c37bb --------- Co-authored-by: cskh <hui.kang@hashicorp.com> fix for , non presence of consul-version meta (#18464) (#18561) * fix for #18406 , non presence of consul-version meta Co-authored-by: Vijay <vijayraghav22@gmail.com> [BACKPORT] 1.16.x manual backport of OSS->CE branch (#18549) Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.16.x (#18570) backport of commit c833fcc Co-authored-by: NiniOak <anita.akaeze@hashicorp.com> Backport of docs: Fix spelling errors across various pages on the site into release/1.16.x (#18537) docs: Fix spelling errors across various pages on the site (#18533) This commit fixes numerous spelling errors across the site and also removes unnecessary whitespace that was present in the edited files. Co-authored-by: Blake Covarrubias <blake@covarrubi.as> Backport of Fix broken link on sameness group page into release/1.16.x (#18588) backport of commit 05dd1a8 Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
asheshvidyut
force-pushed
the
backport/dans/fix-snapshot-save-test/willingly-golden-leopard
branch
from
66477c9 to
3cf0607
Compare
asheshvidyut
requested review from
emilymianeil and
sarahethompson
and removed request for
a team
Contributor
|
@absolutelightning were these changes not needed on the backport branches, or did they get included elsewhere? |
Contributor
included elsewhere |
github-actions
Bot
deleted the
backport/dans/fix-snapshot-save-test/willingly-golden-leopard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18656 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@DanStough
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Small fix for this test. This fails in ENT because the version has
1.17.0+ent, but the test agent version does not have the+entsuffix.The original PR is #18625
Overview of commits