ci: fix filter_changed_files to not silently fail ;)#18723
Closed
nfi-hashicorp wants to merge 2 commits into
Closed
ci: fix filter_changed_files to not silently fail ;)#18723nfi-hashicorp wants to merge 2 commits into
nfi-hashicorp wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
theme/contributing
nfi-hashicorp
added
pr/no-changelog
nfi-hashicorp
commented
Sep 8, 2023
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -euo pipefail | |||
Collaborator
Author
There was a problem hiding this comment.
This won't solve the underlying problem, but it should guard against a silent failure
nfi-hashicorp
commented
Sep 8, 2023
| set -euo pipefail | ||
|
|
||
| # Get the list of changed files | ||
| files_to_check=$(git diff --name-only origin/$GITHUB_BASE_REF) |
Collaborator
Author
There was a problem hiding this comment.
Oh, I'm betting $GITHUB_BASE_REF isn't set on merges to main. In that case, we should just diff HEAD vs HEAD^ I guess?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been failing:
https://github.com/hashicorp/consul/actions/runs/6124071996/job/16623327674