Backport of docs: Remove YAML service registration examples into release/1.15.x#18905
Merged
hc-github-team-consul-core merged 1 commit intoSep 19, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/docs/remove-k8s-yaml-service-registration/typically-meet-lion
branch
from
bb2750c to
de7a901
Compare
hc-github-team-consul-core
force-pushed
the
backport/docs/remove-k8s-yaml-service-registration/typically-meet-lion
branch
from
cab0573 to
9c41249
Compare
github-actions
Bot
added
the
type/docs
github-team-consul-core-pr-approver
approved these changes
Sep 19, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Collaborator
Author
|
🤔 This PR has changes in the |
hc-github-team-consul-core
deleted the
backport/docs/remove-k8s-yaml-service-registration/typically-meet-lion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18877 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Remove YAML service registration examples and replace them with JSON. This is because YAML is not a supported configuration format for the Consul's agent configuration, nor is it supported by the HTTP API.
This commit replaces the YAML examples with JSON and adds additional JSON examples where they were missing.
PR Checklist
Overview of commits