Skip to content

Backport of Fix type of datacenter in Service Resolvers Config Entry into release/1.16.x#19013

Merged
asheshvidyut merged 1 commit into
release/1.16.xfrom
backport/fix-doc/correctly-arriving-gull
Sep 27, 2023
Merged

Backport of Fix type of datacenter in Service Resolvers Config Entry into release/1.16.x#19013
asheshvidyut merged 1 commit into
release/1.16.xfrom
backport/fix-doc/correctly-arriving-gull

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #19004 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "693b299eb1bab484d7afdfc059c7790a8f3de500", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Datacenter inside Redirect map is of type string. As mentioned here also

Fixes the doc.

Links

https://developer.hashicorp.com/consul/docs/connect/config-entries/service-resolver#redirect-datacenter


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/fix-doc/correctly-arriving-gull branch 2 times, most recently from 8bb5fe3 to 5725131 Compare September 27, 2023 01:25
@github-actions github-actions Bot added the type/docs Documentation needs to be created/updated/clarified label Sep 27, 2023
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@asheshvidyut asheshvidyut marked this pull request as ready for review September 27, 2023 01:26
@asheshvidyut asheshvidyut requested a review from a team as a code owner September 27, 2023 01:26
@asheshvidyut asheshvidyut enabled auto-merge (squash) September 27, 2023 01:30
@vercel vercel Bot temporarily deployed to Preview – consul September 27, 2023 01:37 Inactive
@asheshvidyut asheshvidyut merged commit 3c6db54 into release/1.16.x Sep 27, 2023
@asheshvidyut asheshvidyut deleted the backport/fix-doc/correctly-arriving-gull branch September 27, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants