Skip to content

Make raft-wal default when resource-apis is active#19090

Merged
dhiaayachi merged 1 commit into
mainfrom
raft-wal-default-v2-catalog
Oct 6, 2023
Merged

Make raft-wal default when resource-apis is active#19090
dhiaayachi merged 1 commit into
mainfrom
raft-wal-default-v2-catalog

Conversation

@dhiaayachi
Copy link
Copy Markdown
Contributor

Description

This change the raft backend configuration behaviour as follow:

  • If no backend is specified, experiments=["resource-apis"] is set and no boltdb raft file is on disk the backend will be WAL
  • If WAL is set and no boltdb raft file is on disk WAL is used (this is haven't changed)
  • If Boltdb is set boltDB will be used (this is haven't changed)
  • If a db exist on disk using boltdb it will be used (this is haven't changed)

This is still missing the doc part that need to be added, I'm not sure if we add it right away or need to wait for the release.

Testing & Reproduction steps

Added config tests and manually tested that all the combinations above work as expected.

PR Checklist

  • updated test coverage
  • external facing docs updated

@dhiaayachi dhiaayachi requested a review from a team as a code owner October 5, 2023 21:02
@github-actions github-actions Bot added the theme/config Relating to Consul Agent configuration, including reloading label Oct 5, 2023
@dhiaayachi dhiaayachi added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport and removed pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 5, 2023
Copy link
Copy Markdown
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵 🎉

@dhiaayachi
Copy link
Copy Markdown
Contributor Author

@ishustava @rboyer I will merge this as is, we need to document this when we add the documentation for experiments=["resource-apis"]

@dhiaayachi dhiaayachi merged commit ed882e2 into main Oct 6, 2023
@dhiaayachi dhiaayachi deleted the raft-wal-default-v2-catalog branch October 6, 2023 14:24
boruszak added a commit to hashicorp/web-unified-docs that referenced this pull request Apr 10, 2026
## Description

<!-- Please describe why you're making this change and point out any
important details the reviewers
should be aware of. 

Include the target release as well as prior versions if applicable.
-->
The default of `raft_logstore.backend` had changed but was never
doccumented in version 1.21.

## Links

[Make raft-wal default when resource-apis is active
#19090](hashicorp/consul#19090)

## Contributor checklists

Review urgency:

- [ ] ASAP: Bug fixes, broken content, imminent releases
- [ ] 3 days: Small changes, easy reviews
- [ ] 1 week: Default expectation
- [x] Best effort: No urgency

Pull request:

- [x] Verify that the PR is set to merge into the correct base branch
- [ ] Verify that all status checks passed
- [ ] Verify that the preview environment deployed successfully
- [ ] Add additional reviewers if they are not part of assigned groups

Content:

- [ ] I added redirects for any moved or removed pages
- [x] I followed the [Education style
guide](https://github.com/hashicorp/web-unified-docs/tree/main/docs/style-guide)
- [ ] I looked at the local or Vercel build to make sure the content
rendered correctly

## Reviewer checklist

- [ ] This PR is set to merge into the correct base branch.
- [ ] The content does not contain technical inaccuracies.
- [ ] The content follows the Education content and style guides.
- [ ] I have verified and tested changes to instructions for end users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport theme/config Relating to Consul Agent configuration, including reloading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants