Backport of NET-4135 - Fix NodeMeta filtering Catalog List Services API into release/1.16.x

[hc-github-team-consul-core]

Backport

This PR is auto-generated from #18322 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

---

Description

Fixed the working of filter query parameter in /v1/catalog/services API. Fixes - #17422

Testing & Reproduction steps

Followed this tutorial and setup workloads in K8s.
Did curl -

asheshvidyut@asheshvidyut-H2GX766V9T ~/consul (NET-4135) » curl -ks -G http://localhost:8500/v1/catalog/services --data-urlencode filter="NodeMeta[\"consul-network-segment\"] == \"\" and NodeMeta[\"consul-version\"] == \"1.17.0\"" | jq
{
  "consul": []
}
asheshvidyut@asheshvidyut-H2GX766V9T ~/consul (NET-4135) » curl -ks -G http://localhost:8500/v1/catalog/services --data-urlencode filter="NodeMeta[\"synthetic-node\"] == true" | jq
{
  "frontend": [],
  "frontend-sidecar-proxy": [],
  "nginx": [],
  "nginx-sidecar-proxy": [],
  "payments": [],
  "payments-sidecar-proxy": [],
  "postgres": [],
  "postgres-sidecar-proxy": [],
  "products-api": [],
  "products-api-sidecar-proxy": [],
  "public-api": [],
  "public-api-sidecar-proxy": []
}

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

---

Overview of commits

• cef8e3d - 79fdf19 - 91efd2c - 4fa91a6 - 92ed62d - 1a53944 - c7c5876 - db1039a - e475fa6 - dc4f9d1 - ecc8dbf - b8dfd87 - 174f8b0 - 6d1cee7 - 8b21150 - 6d8d396 - f63c251 - 7f6c537 - 6c08f9c - 44f366b - 8c12cbb - 961eeef - 5af1b1c - 1763589 - f475356 - 86b1e28 - aaf6e54 - 4ed56cc - eaed33c - 5d366e8 - 7a95115 - 96421c2 - 94e73db - b7aa37e - 89ed772 - b25d920 - 1141444 - af363ff - ebcf3c3 - 04aae7e

[github-team-consul-core-pr-approver]

Auto approved Consul Bot automated PR

[david-yu]

@absolutelightning I believe you should be able to merge the backports as long as all tests pass successfully without any review from staff engineers.