Backport of acls,catalog,mesh: properly authorize workload selectors on writes into release/1.17.x#19296
Merged
hc-github-team-consul-core merged 1 commit intoOct 19, 2023
Conversation
d191257 to
3611fed
Compare
afabe80 to
f3d9824
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 19, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19260 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
To properly enforce writes on resources that have workload selectors with prefixes, we need another
serviceauthorization rule that allows us to check whether read is allowed within a given prefix. Specifically we need to only allow writes if the policy prefix allows for a wider set of names than the prefix selector on the resource. We should also not allow policies with exact names for prefix matches.Part of NET-3993
Examples:
(when default is deny)
Decision: deny
selector:
policy:
Decision: allow
selector:
policy:
Decision: deny
selector:
policy:
Testing & Reproduction steps
Links
PR Checklist
Overview of commits