Skip to content

[1.15.x] Vault CA bugfixes (#19285)#19337

Merged
kisunji merged 1 commit into
release/1.15.xfrom
kisunji/1.15.x-backport
Oct 23, 2023
Merged

[1.15.x] Vault CA bugfixes (#19285)#19337
kisunji merged 1 commit into
release/1.15.xfrom
kisunji/1.15.x-backport

Conversation

@kisunji
Copy link
Copy Markdown
Contributor

@kisunji kisunji commented Oct 23, 2023

  • Re-add retry logic to Vault token renewal

  • Fix goroutine leak

  • Add test for detecting goroutine leak

  • Add changelog

  • Rename tests

  • Add comment

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 labels Oct 23, 2023
@github-actions github-actions Bot added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Oct 23, 2023
@kisunji kisunji requested a review from cthain October 23, 2023 14:00
@kisunji kisunji mentioned this pull request Oct 23, 2023
@kisunji kisunji enabled auto-merge (squash) October 23, 2023 14:01
* Re-add retry logic to Vault token renewal

* Fix goroutine leak

* Add test for detecting goroutine leak

* Add changelog

* Rename tests

* Add comment
@kisunji kisunji force-pushed the kisunji/1.15.x-backport branch from 465b095 to f2d9a7c Compare October 23, 2023 14:02
Copy link
Copy Markdown
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against #19285 👍

@kisunji kisunji merged commit bb4ea08 into release/1.15.x Oct 23, 2023
@kisunji kisunji deleted the kisunji/1.15.x-backport branch October 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-changelog PR does not need a corresponding .changelog entry theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants