Skip to content

Make retry on connect failure filter on gateway http route filter a bool rather than a bool pointer#19386

Closed
jmurret wants to merge 2 commits into
mainfrom
jm/retry-on-connect-failure
Closed

Make retry on connect failure filter on gateway http route filter a bool rather than a bool pointer#19386
jmurret wants to merge 2 commits into
mainfrom
jm/retry-on-connect-failure

Conversation

@jmurret
Copy link
Copy Markdown
Member

@jmurret jmurret commented Oct 26, 2023

This fixes the TestHTTPRouteRetryAndTimeout failure that is blocking #19365.

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.17 labels Oct 26, 2023
@github-actions github-actions Bot added the theme/api Relating to the HTTP API interface label Oct 26, 2023
@jmurret jmurret marked this pull request as ready for review October 26, 2023 15:53
@jmurret jmurret requested a review from a team as a code owner October 26, 2023 15:53
@jmurret jmurret force-pushed the jm/retry-on-connect-failure branch from 2826dd3 to e175e91 Compare October 26, 2023 17:16
@jmurret jmurret force-pushed the jm/retry-on-connect-failure branch from e175e91 to 4a2fc73 Compare October 26, 2023 21:27
@jmurret jmurret closed this Oct 26, 2023
@github-actions github-actions Bot deleted the jm/retry-on-connect-failure branch August 29, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-changelog PR does not need a corresponding .changelog entry theme/api Relating to the HTTP API interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants