Skip to content

Backport of [NET-6138] security: Bump google.golang.org/grpc to 1.56.3 (CVE-2023-44487) to release/1.14.x#19422

Merged
zalimeni merged 1 commit into
release/1.14.xfrom
net-6138/release/1.14.x
Oct 30, 2023
Merged

Backport of [NET-6138] security: Bump google.golang.org/grpc to 1.56.3 (CVE-2023-44487) to release/1.14.x#19422
zalimeni merged 1 commit into
release/1.14.xfrom
net-6138/release/1.14.x

Conversation

@zalimeni
Copy link
Copy Markdown
Member

@zalimeni zalimeni commented Oct 27, 2023

Backport

This PR is manually generated from #19414 to be assessed for backporting.

This backport also includes various fixes from later release versions required for
tests and linters to pass. See 77f44fa for the majority of these changes.

See #19421 for comments on additional changes required for release/1.15.x and this branch.

The below text is copied from the body of the original PR.


Description

Upgrade google.golang.org/grpc to 1.56.3 (where 1.57.x is already in use, upgrade to 1.57.2) to mitigate CVE-2023-44487.

1.56.3 was chosen as the earliest minor release line to receive a patch for this vulnerability in order to minimize change prior to the 1.17 release of Consul; a later upgrade should consider moving to the latest minor version of gRPC. A review of the release notes and changelog between 1.55.0 and 1.56.3 was conducted to check for unreported breaking changes.

Testing & Reproduction steps

CI tests should continue to pass.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions Bot added pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support labels Oct 27, 2023
@zalimeni zalimeni force-pushed the net-6138/release/1.14.x branch 4 times, most recently from 82b8b40 to 7191d2b Compare October 27, 2023 22:00
@zalimeni zalimeni marked this pull request as ready for review October 27, 2023 22:26
@zalimeni zalimeni requested a review from a team as a code owner October 27, 2023 22:26
Copy link
Copy Markdown
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving base on 👀

@zalimeni zalimeni force-pushed the net-6138/release/1.14.x branch from 7191d2b to 136efc2 Compare October 29, 2023 20:47
This resolves [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487).

Also includes various fixes from later release versions required for
tests and linters to pass. See 77f44fa
for the majority of these changes.
@zalimeni zalimeni force-pushed the net-6138/release/1.14.x branch from 136efc2 to 5b31927 Compare October 29, 2023 20:51
@zalimeni zalimeni merged commit fd59082 into release/1.14.x Oct 30, 2023
@zalimeni zalimeni deleted the net-6138/release/1.14.x branch October 30, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/dependencies PR specifically updates dependencies of project pr/no-backport theme/envoy/xds Related to Envoy support theme/security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants