Added tenancy tests for workload controller #19429
Closed
Ganeshrockz wants to merge 4 commits into
Closed
Conversation
Ganeshrockz
changed the title
Ganeshrockz
added
pr/no-backport
pr/no-changelog
Contributor
erichaberkorn
left a comment
erichaberkorn
left a comment
There was a problem hiding this comment.
Have you tried running this on ENT? It's probably best for PRs to start on the ENT side.
| actualHealth, err := getNodeHealth(context.Background(), suite.runtime, node.Id) | ||
| require.NoError(t, err) | ||
| require.Equal(t, health, actualHealth) | ||
| func (suite *controllerSuite) runTestCaseWithTenancies(name string, t func(*pbresource.Tenancy)) { |
Contributor
There was a problem hiding this comment.
It tests t typically refers to a *testing.T. Could we rename this something else?
Contributor
There was a problem hiding this comment.
Can we do something so we don't need to pass in the name of the parent test? Maybe if this passes a*testing.T, it can use a t.Run to make the subtest?
Contributor
Author
|
Closing this in favour of #19530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist