Skip to content

Backport of Source / local_app golden tests to include all protocols. into release/1.17.x#19489

Closed
hc-github-team-consul-core wants to merge 2 commits into
release/1.17.xfrom
backport/jm/local-app-protocol-test/hardly-noble-aardvark
Closed

Backport of Source / local_app golden tests to include all protocols. into release/1.17.x#19489
hc-github-team-consul-core wants to merge 2 commits into
release/1.17.xfrom
backport/jm/local-app-protocol-test/hardly-noble-aardvark

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #19436 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jmurret
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This PR changes L4 specific tests to cover all protocols. We prefaced them with L4 to originally describe that was the only thing in scope at the moment, but now that we support L7 protocols, the tests no longer need to be L4 specific and really just test how local_app resources are created from workload ports with various protocols.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Nov 2, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • jmurret
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@david-yu
Copy link
Copy Markdown
Contributor

david-yu commented Nov 3, 2023

Looks like backport failed?

@jmurret jmurret marked this pull request as ready for review November 8, 2023 22:24
@jmurret jmurret closed this Nov 8, 2023
@github-actions github-actions Bot deleted the backport/jm/local-app-protocol-test/hardly-noble-aardvark branch August 29, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants