Backport of test: update certs for 10 year expiry into release/1.16.x#19560
Merged
hc-github-team-consul-core merged 1 commit intoNov 7, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-6450/update-cert-for-10-years/precisely-infinite-gecko
branch
from
902eca3 to
2e96f9a
Compare
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-6450/update-cert-for-10-years/precisely-infinite-gecko
branch
from
72e76eb to
ed0fc8a
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 7, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
Bot
added
theme/cli
hc-github-team-consul-core
deleted the
backport/dans/NET-6450/update-cert-for-10-years/precisely-infinite-gecko
branch
mbrulatout
pushed a commit
to criteo-forks/consul
that referenced
this pull request
Dec 28, 2023
…hashicorp#19560) backport of commit d6283a9 Co-authored-by: DanStough <dan.stough@hashicorp.com>
mbrulatout
pushed a commit
to criteo-forks/consul
that referenced
this pull request
Dec 28, 2023
…hashicorp#19560) backport of commit d6283a9 Co-authored-by: DanStough <dan.stough@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19481 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
Updates to make sure that test certs expire after ~10 years. I also noticed some root CAs will expire in the next couple of years, so those are also updated.
There is one remaining cert that expires < 5 years,
./test/ca_path/cert1.crt. I didn't know off the top of my head how to replicate the error case, so we will revisit in 2025?Testing & Reproduction steps
Tests are run in CI.
PR Checklist
Overview of commits