Skip to content

Backport of [Docs] Update admin-partitions.mdx into release/1.14.x#19629

Closed
hc-github-team-consul-core wants to merge 2 commits into
release/1.14.xfrom
backport/am-ak-patch-1/really-stirring-flounder
Closed

Backport of [Docs] Update admin-partitions.mdx into release/1.14.x#19629
hc-github-team-consul-core wants to merge 2 commits into
release/1.14.xfrom
backport/am-ak-patch-1/really-stirring-flounder

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #18430 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@im2nguyen
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "88434d96f7bf7ba3349f70fe71141f9c41ed7464", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Adding a note on DNS queries requiring the presence of a Consul Client in the Admin partition

Testing & Reproduction steps

The consul-dns endpoints are the consul clients and servers as seen In the Helm chart consul/templates/dns-service.yaml
selector:
app: {{ template "consul.name" . }}
release: "{{ .Release.Name }}"
hasDNS: "true"

All components have the first two labels for app and release but only consul clients and servers have the last one hasDNS so it will only match clients AND servers

grep hasDNS ./* 2> /dev/null
./client-daemonset.yaml: hasDNS: "true"
./dns-service.yaml: hasDNS: "true"
./server-statefulset.yaml: hasDNS: "true"

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/am-ak-patch-1/really-stirring-flounder branch from 6414858 to bd4e6bc Compare November 14, 2023 17:11
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/am-ak-patch-1/really-stirring-flounder branch from 13dbd0c to 8b70f70 Compare November 14, 2023 17:11
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions Bot added the type/docs Documentation needs to be created/updated/clarified label Nov 14, 2023
@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@im2nguyen im2nguyen marked this pull request as ready for review November 14, 2023 17:27
@im2nguyen im2nguyen requested a review from a team as a code owner November 14, 2023 17:27
@im2nguyen im2nguyen enabled auto-merge (squash) November 14, 2023 17:27
@github-actions
Copy link
Copy Markdown

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions Bot added the meta/stale Automatically flagged for inactivity by stalebot label Jan 14, 2024
@github-actions
Copy link
Copy Markdown

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions Bot closed this Feb 15, 2024
auto-merge was automatically disabled February 15, 2024 01:26

Pull request was closed

@github-actions github-actions Bot deleted the backport/am-ak-patch-1/really-stirring-flounder branch August 29, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta/stale Automatically flagged for inactivity by stalebot type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants