agent: remove data race in agent config#20200
Merged
Merged
Conversation
This was caused in #18681
rboyer
added
pr/no-changelog
hashi-derek
approved these changes
Jan 12, 2024
rboyer
added a commit
that referenced
this pull request
Jan 12, 2024
To fix an issue displaying the current reloaded config in the v1/agent/self endpoint #18681 caused the agent's internal config struct member to be deepcopied and replaced on reload. This is not safe because the field is not protected by a lock, nor should it be due to how it is accessed by the rest of the system. This PR does the same deepcopy, but into a new field solely for the point of capturing the current reloaded values for display purposes. If there has been no reload then the original config is used.
rboyer
added a commit
that referenced
this pull request
Jan 12, 2024
To fix an issue displaying the current reloaded config in the v1/agent/self endpoint #18681 caused the agent's internal config struct member to be deepcopied and replaced on reload. This is not safe because the field is not protected by a lock, nor should it be due to how it is accessed by the rest of the system. This PR does the same deepcopy, but into a new field solely for the point of capturing the current reloaded values for display purposes. If there has been no reload then the original config is used.
Collaborator
|
@rboyer, a backport is missing for this PR [20200] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description: |
3 similar comments
Collaborator
|
@rboyer, a backport is missing for this PR [20200] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description: |
Collaborator
|
@rboyer, a backport is missing for this PR [20200] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description: |
Collaborator
|
@rboyer, a backport is missing for this PR [20200] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description: |
rboyer
added a commit
that referenced
this pull request
Jan 16, 2024
….x (#20202) [1.16.x] agent: remove data race in agent config (#20200) To fix an issue displaying the current reloaded config in the v1/agent/self endpoint #18681 caused the agent's internal config struct member to be deepcopied and replaced on reload. This is not safe because the field is not protected by a lock, nor should it be due to how it is accessed by the rest of the system. This PR does the same deepcopy, but into a new field solely for the point of capturing the current reloaded values for display purposes. If there has been no reload then the original config is used. Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>
rboyer
added a commit
that referenced
this pull request
Jan 16, 2024
….x (#20201) [1.15.x] agent: remove data race in agent config (#20200) To fix an issue displaying the current reloaded config in the v1/agent/self endpoint #18681 caused the agent's internal config struct member to be deepcopied and replaced on reload. This is not safe because the field is not protected by a lock, nor should it be due to how it is accessed by the rest of the system. This PR does the same deepcopy, but into a new field solely for the point of capturing the current reloaded values for display purposes. If there has been no reload then the original config is used. Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix an issue displaying the current reloaded config in the
v1/agent/selfendpoint #18681 caused the agent's internalconfigstruct member to be deepcopied and replaced on reload.This is not safe because the field is not protected by a lock, nor should it be due to how it is accessed by the rest of the system.
This PR does the same deepcopy, but into a new field solely for the point of capturing the current reloaded values for display purposes. If there has been no reload then the original config is used.