Backport of [NET-6741] make: Add target for updating dependencies across all modules into release/1.15.x#20683
Closed
hc-github-team-consul-core wants to merge 1 commit into
Conversation
23fce82 to
b251def
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
Feb 21, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Member
|
Closing in favor of #20687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19785 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
To enable more consistent and error-proof dependency management, add a Make target that will set a dependency version across all submodules that require it.
Also runs
go mod tidy. This first ensures the dependency addition is reverted if the module in question does not require it; it also ensures that any additional cleanup needed ingo.mod/go.sumis applied.Note on approach vs.
go.workAt one point, it seemed we could avoid executing
go getper eachgo.modby instead moving to a versionedgo.workand using workspace-based dependency management commands. Though there's still reasons to move togo.workbeyond this change, it probably won't work for bumping dependencies conveniently:go work syncconsolidates versions using MVS, so in practice, it seems we still need to use a visit-all approach to be able to blindly bump a given dependency only where it’s used.go work syncsimply enforces consistency across all go.mod files once any go.mod is updated (docs):Description
Simplify dependency management, particularly for addressing CVEs where a consistent minimum version is required.
Example run:
PR Checklist
Overview of commits