Backport of ci: fix CI skip script hole into release/1.19.x#21747
Merged
zalimeni merged 1 commit intoSep 16, 2024
Merged
Conversation
github-team-consul-core-pr-approver
approved these changes
Sep 16, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
Bot
added
the
theme/contributing
zalimeni
deleted the
backport/zalimeni/fix-scan-ci-skip-config/secretly-trusty-sunbeam
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21741 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
In some environments, the script will not fail despite
SKIP_CHECK_BRANCHbeing unset, leading to the script explicitly skipping CI when it should fail fast.Meta-comment: we should consider transitioning to paths-ignore. Even though it'd be a bit more copypasta, the upside is we can't silently skip and pass tests + security scans by accident if a future bug or misconfiguration occurs.
Description
Example script failure -> skipped CI: https://github.com/hashicorp/consul/actions/runs/10851790913/job/30116333377#step:3:5 (this workflow no longer uses the script, and relies on
paths-ignoreinstead).Testing
PR Checklist
Overview of commits