Skip to content

Delete old redundant encryption MDX file#21834

Merged
zalimeni merged 1 commit into
release/1.20.xfrom
rm/delete-old-encryption-file
Oct 16, 2024
Merged

Delete old redundant encryption MDX file#21834
zalimeni merged 1 commit into
release/1.20.xfrom
rm/delete-old-encryption-file

Conversation

@rmainwork
Copy link
Copy Markdown
Contributor

@rmainwork rmainwork commented Oct 16, 2024

Description

This file path (security/encryption.mdx updated a year ago) is conflicting with another file path (security/encrpytion/index.mdx updated 2 weeks ago).

This is causing the Vercel build to fail since the GitHub runner cannot distinguish between the file encryption.mdx and the path
encryption/index.mdx

This file specifically was chosen for deletion in preference to the other due to it being more recently updated.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

This file path (`security/encryption.mdx` updated a year ago) is conflicting
with another file path (`security/encrpytion/index.mdx` updated 2 weeks
ago). This is causing the Vercel build to fail since the GitHub runner
cannot distinguish between the file `encryption.mdx` and the path
`encryption/index.mdx`

This one specifically was chosen for deletion due to it last being
updated a year ago vs `encryption/idex.mdx` being updated 2 weeks ago
@rmainwork rmainwork requested a review from a team as a code owner October 16, 2024 13:40
@github-actions github-actions Bot added the type/docs Documentation needs to be created/updated/clarified label Oct 16, 2024
@zalimeni
Copy link
Copy Markdown
Member

zalimeni commented Oct 16, 2024

It looks like the older file was removed in #21509, but that PR backported to release/1.19.x, and not release/1.20.x, so this seems correct to me - but probably needs the entire PR backported, not just this removal?

@boruszak just double checking, is it expected that we didn't backport the original PR's refactor to release/1.18.x and release/1.15.x (LTS)?

@boruszak
Copy link
Copy Markdown
Contributor

Thanks for the callout @zalimeni! We should backport this to v1.15 and v1.18 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants