Backport of api: remove dependency on proto-public, protobuf, and grpc into release/1.20.x#21845
Merged
zalimeni merged 3 commits intoOct 17, 2024
Conversation
hc-github-team-consul-core
force-pushed
the
backport/rboyer/remove-proto-dep-from-api/blindly-stunning-wallaby
branch
from
5e4b002 to
5681458
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 17, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
zalimeni
deleted the
backport/rboyer/remove-proto-dep-from-api/blindly-stunning-wallaby
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21780 to be assessed for backporting due to the inclusion of the label backport/1.20.
The below text is copied from the body of the original PR.
Description
The api submodule has a test-only dependency on
proto-public. This has the unfortunate side effect of making anybody importingapinavigate the dependency maze that is protobuf + grpc for no reason.This PR removes the need from the dependency.
Overview of commits