Backport of [Security] SECVULN-8621: Fix XSS Vulnerability where content-type header wasn't explicitly set in API requests into release/1.20.x#21976
Merged
Conversation
6e47fd8 to
0e77e30
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 27, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21930 to be assessed for backporting due to the inclusion of the label backport/1.20.
The below text is copied from the body of the original PR.
Description
ensureContentTypeHeadermiddleware to set the responseContent-Typeto match the type of content that the server will process.SOLUTION
ensureContentTypeHeadermiddleware is used to determine if the content-type set in the API request is the expected content type. If it's not a match:NOTE: The same function is used in
doRequestfunction which is used in processing CLI requests to the Consul API.Testing & Reproduction steps
Updated unit tests to add additional checks for content-type header
Vercel should deploy UI with no errors
MANUAL TESTING
Before Changes
After Changes
PR Checklist
Overview of commits