Backport of Send TLS SNI in JWT auth provider into release/1.20.x#22185
Closed
hc-github-team-consul-core wants to merge 14 commits into
Closed
Conversation
2bf6667 to
f10b0f1
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 24, 2025
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22177 to be assessed for backporting due to the inclusion of the label backport/1.20.
The below text is copied from the body of the original PR.
Description
Send hostname in SNI while initiating a TLS connection for JWTProvider. This is required by certain JWT providers such as Auth0 and not having it leads to a handshake error immediately after CLIENT_HELLO.
This is configured by setting the UseSNI flag to true in JWT Provider Config Entry for remote JWKS.
Testing & Reproduction steps
Run consul agent -
consul agent -devin the terminal.Replace
PROVIDER_NAME,JWKS_URIandJWKS_URIinjwt.hclwith actual values ref. ReplacePROVIDER_NAMEinintentions.hclwith the same name injwt.hcl. (remove .txt extension cos github doen't allow .hcl attachements).In a different terminal, using consul cli, write the following configs (remove .txt extension cos github doen't allow .hcl attachements):
consul config write proxy-defaults.hcl; consul config write jwt.hcl; consul config write intention.hcl; consul services register counting.hclcounting.hcl.txt
intention.hcl.txt
jwt.hcl.txt
proxy-defaults.hcl.txt
Connect Envoy using -
consul connect envoy -sidecar-for counting -- -l debugUseSNIis present injwt.hcl. When this is set to false or removed, you will see503in the Envoy logs:Links
PR Checklist
Overview of commits