Backport of [Feature] Invalidate session check if associated session is deleted into release/1.20.x#22232
Conversation
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
…fully-valued-glider
…ates, improving dynamic health monitoring
…ates, improving dynamic health monitoring
…ates, improving dynamic health monitoring
|
Substituted by #22236, hence closing this PR. |
Backport
This PR is auto-generated from #22227 to be assessed for backporting due to the inclusion of the label backport/1.20.
🚨
The person who merged in the original PR is:
@srahul3
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Background
The ESM is also requested to go agentless, being agentless it becomes challenging to keep track of the health of the artificial node.
Proposal
This pull request introduces a new feature to support Consul Session to update the state of the health-checks. The constraint is, the health-check needs to be of type
sessionand bothsessionand thehealth-checkshall belong to common parent node.The idea is to use the sessions to keep track of health status. During partition of ESM crash, the session is deleted and hence, the changes in this PR enables to make the associated
sessionchecks to be critical. On thus event, the other ESM instance picks up the leadership and re-distribute the responsibility among remaining health ESM instances.There is need for a regular session to be created with name
<session-name>There is new check which is proposed of type
Type="session"andDefinition.SessionName=<session-name>.** Code sequence **
session. This session health-check also has a field which suggest the session name. If this check's session name matches with this session name, the check's name is marked critical.Testing
Unit test added
PR Checklist
Overview of commits