Skip to content

ui: Support for Node Identities#8137

Merged
johncowen merged 9 commits into
masterfrom
ui/feature/node-identities
Jun 23, 2020
Merged

ui: Support for Node Identities#8137
johncowen merged 9 commits into
masterfrom
ui/feature/node-identities

Conversation

@johncowen
Copy link
Copy Markdown
Contributor

@johncowen johncowen commented Jun 17, 2020

#7970 adds backend support for Node Identities, which are a templated policy similar to Service Identities.

This PR adds Phase 1 frontend UI support for Node Identities:

  1. Amend ember-data layer for policies to deal with NodeIdentities. This uses the same approach as with ServiceIdentities i.e. we merge and unmerge all identities with policies. All of these policies are actually 'Templated Policies', normal policies having an empty template, in other words the rules for the normal policy are 100% user defined, all other policies use a template.

  2. Specifically highlight Node Identities and Service Identities in the ConsulTokenList component.

Screenshot 2020-06-18 at 13 02 41

This will be replicated in the role listing via a new ConsulRoleList component in a later PR ontop of this branch.

  1. Add an option to select the Node Identity 'template' to use for Policy creation in the PolicyForm.

Screenshot 2020-06-18 at 13 03 24

  1. Ensure that during listing of Policies in the Policy preview listings, that NodeIdentities can also be previewed.

Screenshot 2020-06-18 at 13 04 01

@johncowen johncowen added theme/ui Anything related to the UI backport/1.8 labels Jun 17, 2020
@johncowen johncowen added this to the 1.8.x milestone Jun 18, 2020
@johncowen johncowen marked this pull request as ready for review June 18, 2020 12:05
@johncowen johncowen requested a review from kaxcode June 18, 2020 12:05
@johncowen johncowen force-pushed the ui/feature/node-identities branch from 6e0ffe3 to 1b94dad Compare June 18, 2020 13:48
Copy link
Copy Markdown
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ LGTM

@johncowen johncowen force-pushed the ui/feature/node-identities branch from 7d4fb05 to 215ef0f Compare June 18, 2020 13:57
@johncowen johncowen merged commit 4c58f94 into master Jun 23, 2020
@johncowen johncowen deleted the ui/feature/node-identities branch June 23, 2020 08:59
@hashicorp-ci
Copy link
Copy Markdown
Contributor

🍒✅ Cherry pick of commit 4c58f94 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Jun 23, 2020
* Add all the new data required for NodeIdentities

* Add potential NodeIdentity to the token list component

* Amend the policy-form/selector to allow node identity creation

* Fix up CSS for radio buttons and select label

* Add node-identity policy template component

* Fix up and add acceptance tests for NodeIndentities

* Make sure policy previews take node identities into account

* Only show certain policy markup if those we have those policies

* Potentially temporarily hide dt's that don't have icons yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/ui Anything related to the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants