Add support for -ca-path option in the connect envoy command#8606
Merged
hanshasselberg merged 3 commits intoSep 8, 2020
Conversation
Member
Contributor
Contributor
|
🍒✅ Cherry pick of commit a1fe711 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Sep 8, 2020
* Add support for -ca-path option in the connect envoy command * Adding changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
consul connect envoyCLI currently only takes CA certs that are provided using the-ca-fileoption. In some situations more then one CA file need to be used and therefore the `-ca-path* option exists in the Consul agent. However this option is not implemented for envoy itself.Starting an envoy instance using the
consul connect envoycommands using the -ca-path options results in an error.consul connect envoy -ca-path="/path/to/some/cafiles/folder" -mesh-gateway -register -grpc-addr=https://127.0.0.1:8502This PR fixes this by adding support for -ca-path for envoy as well.