Skip to content

connect: if the token given to the vault provider returns no data avoid a panic#9806

Merged
rboyer merged 2 commits into
masterfrom
better-vault-circular-dep-error
Feb 22, 2021
Merged

connect: if the token given to the vault provider returns no data avoid a panic#9806
rboyer merged 2 commits into
masterfrom
better-vault-circular-dep-error

Conversation

@rboyer
Copy link
Copy Markdown
Member

@rboyer rboyer commented Feb 22, 2021

Improves #9800

@rboyer rboyer requested review from a team and kyhavlov February 22, 2021 19:48
@rboyer rboyer self-assigned this Feb 22, 2021
@github-actions github-actions Bot added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Feb 22, 2021
@hashicorp-ci
Copy link
Copy Markdown
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

@rboyer rboyer force-pushed the better-vault-circular-dep-error branch from 0e8a600 to e10677c Compare February 22, 2021 19:52
@rboyer rboyer changed the title connect: if the token given to the vault provider returns no data avoid panic connect: if the token given to the vault provider returns no data avoid a panic Feb 22, 2021
@vercel vercel Bot temporarily deployed to Preview – consul February 22, 2021 19:52 Inactive
@vercel vercel Bot temporarily deployed to Preview – consul-ui-staging February 22, 2021 19:52 Inactive
@rboyer rboyer merged commit a0d2643 into master Feb 22, 2021
@rboyer rboyer deleted the better-vault-circular-dep-error branch February 22, 2021 20:08
@hashicorp-ci
Copy link
Copy Markdown
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/330549.

@hashicorp-ci
Copy link
Copy Markdown
Contributor

🍒✅ Cherry pick of commit a0d2643 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 22, 2021
@hashicorp-ci
Copy link
Copy Markdown
Contributor

🍒✅ Cherry pick of commit a0d2643 onto release/1.8.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants