Skip to content

example and default syslog CTS settings#9816

Closed
eikenb wants to merge 0 commit into
nia/docs-0.1.0-betafrom
docs-nia-syslog
Closed

example and default syslog CTS settings#9816
eikenb wants to merge 0 commit into
nia/docs-0.1.0-betafrom
docs-nia-syslog

Conversation

@eikenb
Copy link
Copy Markdown
Contributor

@eikenb eikenb commented Feb 23, 2021

Kept it simple and purposely left off 'enabled' to highlight option that it is auto-enabled if any other value is set.

@eikenb eikenb added type/docs Documentation needs to be created/updated/clarified theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Feb 23, 2021
@eikenb eikenb requested a review from a team February 23, 2021 21:02
@hashicorp-ci
Copy link
Copy Markdown
Contributor

hashicorp-ci commented Feb 23, 2021

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hashicorp-ci
Copy link
Copy Markdown
Contributor

hashicorp-ci commented Feb 23, 2021

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

lornasong
lornasong reviewed Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick question about the tagging for the PR. I've typically seen PRs against master additionally have the type/docs-cherrypick tag so that the consul.io docs update immediately on merge. Otherwise, I see only the type/docs tag for PRs against our feature branch (currently nia/docs-0.1.0-beta) so the consul.io docs update when the feature branch merges. I'm personally not sure what will happen on merge for this PR and wanted to double-check if the master branch + no cherrypick tag combo is intentional?

@eikenb
Copy link
Copy Markdown
Contributor Author

eikenb commented Feb 23, 2021

@lornasong Oh... thanks. Double checked all the labels and stuff but totally forgot to submit the PR against our beta-docs branch. Fixing that.

@eikenb eikenb changed the base branch from master to nia/docs-0.1.0-beta February 23, 2021 21:45
@eikenb
Copy link
Copy Markdown
Contributor Author

eikenb commented Feb 23, 2021 •
edited
Loading

Ok, that didn't work (editing it to use the nia/docs-0.1.0-beta branch)... going to re-submit.

@eikenb eikenb closed this Feb 23, 2021
@eikenb eikenb deleted the docs-nia-syslog branch February 24, 2021 20:05
@hashicorp-ci
Copy link
Copy Markdown
Contributor

hashicorp-ci commented Mar 5, 2021

🍒✅ Cherry pick of commit b1d3c80 onto release/1.9.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lornasong lornasong lornasong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eikenb @hashicorp-ci @lornasong