Skip to content

Fix .hbs file copyright parsing by supporting indented content #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CreatorHead merged 1 commit into from
Feb 3, 2026
Merged

Fix .hbs file copyright parsing by supporting indented content #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions licensecheck/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ var commentPrefixes = []string{
"// ", "//",
"# ", "#",
"% ", "%",
" ",
"* ", "*",
}

Expand Down
69 changes: 69 additions & 0 deletions licensecheck/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package licensecheck

import (
"fmt"
"os"
"path/filepath"
"strconv"
Expand Down Expand Up @@ -98,6 +99,20 @@ func TestParseCopyrightLine(t *testing.T) {
TrailingText: "",
},
},
{
name: "Handlebars indented copyright",
line: " Copyright IBM Corp. 2021, 2025",
lineNum: 2,
expectedInfo: &CopyrightInfo{
LineNumber: 2,
OriginalLine: " Copyright IBM Corp. 2021, 2025",
Holder: "IBM Corp.",
StartYear: 2021,
EndYear: 2025,
Prefix: " ",
TrailingText: "",
},
},
}

for _, tt := range tests {
Expand Down Expand Up @@ -728,6 +743,7 @@ func TestExtractCommentPrefix_AllFormats(t *testing.T) {
{"Erlang style", "% Copyright", "% "},
{"Haskell/SQL style", "-- Copyright", "-- "},
{"Handlebars style", "{{! Copyright", "{{! "},
{"Handlebars indented content", " Copyright", " "},
{"OCaml style", "(** Copyright", "(** "},
{"EJS template style", "<%/* Copyright", "<%/* "},
{"JSDoc style", "/** Copyright", "/** "},
Expand Down Expand Up @@ -837,3 +853,56 @@ func TestCalculateYearUpdates(t *testing.T) {
assert.Equal(t, currentYear, newEnd)
})
}

func TestUpdateCopyrightHeader_HandlebarsFiles(t *testing.T) {
currentYear := time.Now().Year()
tempDir := t.TempDir()
testFile := filepath.Join(tempDir, "test.hbs")

// Test .hbs file with multi-line comment format
initialContent := `{{!
Copyright IBM Corp. 2021, 2025
SPDX-License-Identifier: MPL-2.0
}}

<html>
<body>
<h1>{{title}}</h1>
</body>
</html>`

err := os.WriteFile(testFile, []byte(initialContent), 0644)
require.NoError(t, err)

// Test that it needs an update
needsUpdate, err := NeedsUpdate(testFile, "IBM Corp.", 2021, true)
require.NoError(t, err)
assert.True(t, needsUpdate, "Should detect that .hbs file needs copyright update")

// Test updating the copyright header
modified, err := UpdateCopyrightHeader(testFile, "IBM Corp.", 2021, true)
require.NoError(t, err)
assert.True(t, modified, "Should successfully update .hbs file copyright")

// Verify the content was updated correctly
content, err := os.ReadFile(testFile)
require.NoError(t, err)

expectedContent := fmt.Sprintf(`{{!
Copyright IBM Corp. 2021, %d
SPDX-License-Identifier: MPL-2.0
}}

<html>
<body>
<h1>{{title}}</h1>
</body>
</html>`, currentYear)

assert.Equal(t, expectedContent, string(content))

// Test that it doesn't need another update
needsUpdate2, err := NeedsUpdate(testFile, "IBM Corp.", 2021, true)
require.NoError(t, err)
assert.False(t, needsUpdate2, "Should not need another update after being updated to current year")
}
Loading