Don't start backoff timer if it would exceed context deadline#284
Open
c-tonneslan wants to merge 1 commit into
Open
Don't start backoff timer if it would exceed context deadline#284c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
If the backoff wait time would push past the context deadline, there's no point starting the timer at all. We'd just block until the deadline fires and get context.DeadlineExceeded anyway. Instead, check upfront and return immediately so callers get the error without the unnecessary wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the calculated backoff wait would push past the context deadline, we're just going to block until the deadline fires and get
context.DeadlineExceededanyway. This change checks for that upfront and returns immediately instead of sleeping unnecessarily.The fix is a single deadline check before
time.NewTimer:This makes callers with tight deadlines get the error back faster, without the full backoff sleep eating into their remaining budget.
Existing tests pass (
go test ./...).Fixes #272