Skip to content

plugincontainer: upgrade docker/docker package to v26.1.5#126

Merged
johanbrandhorst merged 1 commit into
hashicorp:mainfrom
odvarkadaniel:bump-docker-version
Aug 1, 2024
Merged

plugincontainer: upgrade docker/docker package to v26.1.5#126
johanbrandhorst merged 1 commit into
hashicorp:mainfrom
odvarkadaniel:bump-docker-version

Conversation

@odvarkadaniel
Copy link
Copy Markdown
Contributor

@odvarkadaniel odvarkadaniel commented Apr 26, 2024

I am currently having issues with hashicorp/vault importing go-secure-stdlib/plugincontainer which still imports an older version of docker/docker package which is causing issues with container types being migrated to a different location.

@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app Bot commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@JadeLeng
Copy link
Copy Markdown

+1 to this, is there any estimate on when this can be merged?

@dmitryax
Copy link
Copy Markdown

+1

This issue is blocking library users from upgrading other dependencies that rely on newer docker library version.

cc @jefferai @johanbrandhorst @ddebko

Copy link
Copy Markdown
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the fix, let me see if we can merge this.

Comment thread plugincontainer/go.mod
@johanbrandhorst
Copy link
Copy Markdown
Contributor

As you can see in the status of this PR, we were able to run the tests and unfortunately they are failing for plugincontainer. I don't believe it's due to the changes in this PR though, as they are failing in the same way on main: https://github.com/hashicorp/go-secure-stdlib/actions/runs/10085652518. I've opened #129 to fix the tests. Once this has been merged, if we could rebase this PR we should be good to go.

@johanbrandhorst
Copy link
Copy Markdown
Contributor

So that fix wasn't as straightforward as I had hoped. I wrote up a summary of what seems to be going on, but if you want this PR merged soon, please consider contributing to my PR first so we can fix the tests and ensure that this update is safe. See #129 (comment). Thank you!

@wyuzheng
Copy link
Copy Markdown

+1 on this. We are also blocked from bumping Docker to version 26.x. We would really appreciate your help in closing the gap and merging this PR.

Comment thread plugincontainer/go.mod Outdated
@pulkits15
Copy link
Copy Markdown

+1
This issue is blocking us from fixing CVEs. Is there any estimate of when this will be merged and released?
Thanks!

@johanbrandhorst
Copy link
Copy Markdown
Contributor

Please rebase on main, that should fix the CI runs!

@odvarkadaniel
Copy link
Copy Markdown
Contributor Author

Please rebase on main, that should fix the CI runs!

@johanbrandhorst rebased

@johanbrandhorst
Copy link
Copy Markdown
Contributor

I pushed your branch separately so we run CI

@johanbrandhorst johanbrandhorst merged commit fab9dfb into hashicorp:main Aug 1, 2024
@johanbrandhorst
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

@odvarkadaniel odvarkadaniel changed the title plugincontainer: upgrade docker/docker package to v26.1.0 plugincontainer: upgrade docker/docker package to v26.1.5 Aug 1, 2024
@odvarkadaniel odvarkadaniel deleted the bump-docker-version branch August 1, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants