plugincontainer: upgrade docker/docker package to v26.1.5#126
Conversation
ca9e7a3 to
4af81bf
Compare
|
+1 to this, is there any estimate on when this can be merged? |
|
+1 This issue is blocking library users from upgrading other dependencies that rely on newer docker library version. |
johanbrandhorst
left a comment
There was a problem hiding this comment.
This LGTM, thanks for the fix, let me see if we can merge this.
|
As you can see in the status of this PR, we were able to run the tests and unfortunately they are failing for |
|
So that fix wasn't as straightforward as I had hoped. I wrote up a summary of what seems to be going on, but if you want this PR merged soon, please consider contributing to my PR first so we can fix the tests and ensure that this update is safe. See #129 (comment). Thank you! |
8d8fa92 to
4af81bf
Compare
|
+1 on this. We are also blocked from bumping Docker to version 26.x. We would really appreciate your help in closing the gap and merging this PR. |
|
+1 |
|
Please rebase on |
4af81bf to
08d73e0
Compare
@johanbrandhorst rebased |
|
I pushed your branch separately so we run CI |
|
Thanks for your contribution! |
I am currently having issues with
hashicorp/vaultimportinggo-secure-stdlib/plugincontainerwhich still imports an older version ofdocker/dockerpackage which is causing issues with container types being migrated to a different location.