Skip to content

plugincontainer: fix image build #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanbrandhorst merged 4 commits into from
Aug 1, 2024
Merged

plugincontainer: fix image build #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a19e8fd
plugincontainer: fix image build
johanbrandhorst Jul 25, 2024
1b8003b
Try making it executable
johanbrandhorst Jul 25, 2024
5bc659a
🤦
johanbrandhorst Jul 25, 2024
ec7f39d
Hopefully fix build 🤞
johanbrandhorst Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
(
set -e
ARCH="$(uname -m)"
URL="https://storage.googleapis.com/gvisor/releases/release/latest/${ARCH}"
URL="https://storage.googleapis.com/gvisor/releases/release/20240311/${ARCH}"
wget --quiet "${URL}/runsc" "${URL}/runsc.sha512" \
"${URL}/containerd-shim-runsc-v1" "${URL}/containerd-shim-runsc-v1.sha512"
sha512sum -c runsc.sha512 \
Expand Down
9 changes: 5 additions & 4 deletions plugincontainer/examples/container/Dockerfile
View file
Open in desktop
Comment thread
johanbrandhorst marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ COPY go-plugin-counter /bin/go-plugin-counter

ENTRYPOINT [ "/bin/go-plugin-counter" ]

FROM docker.mirror.hashicorp.services/ubuntu as nonroot
# This is docker.mirror.hashicorp.services/ubuntu:24.04 as of 2024-07-31.
FROM docker.mirror.hashicorp.services/ubuntu@sha256:2e863c44b718727c860746568e1d54afd13b2fa71b160f5cd9058fc436217b30 as nonroot
Comment thread
johanbrandhorst marked this conversation as resolved.

COPY go-plugin-counter /bin/go-plugin-counter

RUN apt-get update && apt-get install -y libcap2-bin acl && \
addgroup --system nonroot && \
adduser --system --ingroup nonroot nonroot && \
groupadd --system nonroot && \
useradd --system -g nonroot nonroot && \
chown -R nonroot:nonroot /bin/go-plugin-counter && \
cp /bin/go-plugin-counter /bin/go-plugin-counter-mlock && \
setcap cap_ipc_lock=+ep /bin/go-plugin-counter-mlock
Expand All @@ -27,4 +28,4 @@ FROM nonroot as nonroot-mlock
ENTRYPOINT [ "/bin/go-plugin-counter-mlock" ]

# Set root as the default image.
FROM root
FROM root