Bug: rc1 is greater than rc11#51
Closed
nodefortytwo wants to merge 1 commit into
Closed
Conversation
|
|
|
@cotarg Can you or someone else merge this? It's a breaking bug in a very common situation. |
Member
|
@ericmillin This is only an update to test files. This isn't a bug in the library itself. |
Member
|
Or to be more clear -- if it is a bug in the library itself, this PR doesn't address it. |
Author
|
As you can see the original title was simply to add tests to ensure this case is considered. there is no bug in the library. |
Author
|
Seems crazy that adding two test cases should take years to merge :) |
Author
|
closing this as its annoying to have in my open PR list for years.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that 1.0.0-rc1 is a fairly standard semver format and one would expect that rc11 is greater than rc1