Skip to content

Backport of acl: fixes a bug where client RPC's fail for node pool "all" into release/2.0.x#27993

Merged
mismithhisler merged 1 commit into
release/2.0.xfrom
backport/b-fix-client-acl-node-pool-all/partly-saving-katydid
May 18, 2026
Merged

Backport of acl: fixes a bug where client RPC's fail for node pool "all" into release/2.0.x#27993
mismithhisler merged 1 commit into
release/2.0.xfrom
backport/b-fix-client-acl-node-pool-all/partly-saving-katydid

Conversation

@hc-github-team-nomad-core
Copy link
Copy Markdown
Contributor

Backport

This PR is auto-generated from #27973 to be assessed for backporting due to the inclusion of the label backport/2.0.x.

The below text is copied from the body of the original PR.


Description

These changes add ACL code to handle client RPC's where the requested entitity is in node_pool = "all". Without this, multiple client RPC endpoints will fail whenever a job is created in "all" nodepools.

In a followup PR, we should be using the already defined node.IsInPool, but it's going to take a small/medium refactor to get working nicely. The included E2E test should catch any future regressions.

Testing & Reproduction steps

Links

Fixes: #27961

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.


Overview of commits

@mismithhisler mismithhisler merged commit ae30e9c into release/2.0.x May 18, 2026
31 checks passed
@mismithhisler mismithhisler deleted the backport/b-fix-client-acl-node-pool-all/partly-saving-katydid branch May 18, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants