Skip to content

Only treat ssh exit errors as errors #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mwhooker wants to merge 1 commit into from
Closed

Only treat ssh exit errors as errors #4010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions communicator/ssh/communicator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,14 @@ func (c *comm) Start(cmd *packer.RemoteCmd) (err error) {
switch err.(type) {
case *ssh.ExitError:
exitStatus = err.(*ssh.ExitError).ExitStatus()
log.Printf("Remote command exited with '%d': %s", exitStatus, cmd.Command)
log.Printf("Remote command exited with '%d': %s",
exitStatus, cmd.Command)
case *ssh.ExitMissingError:
log.Printf("Remote command exited without exit status or exit signal.")
exitStatus = -1
log.Printf("Remote command exited without exit status or " +
"exit signal. If your ssh server restarted intentionally, " +
"you can safely ignore this. Continuing.")
default:
log.Printf("Error occurred waiting for ssh session: %s", err.Error())
exitStatus = -1
log.Printf("Error occurred waiting for ssh session: %s. Continuing.", err.Error())
}
}
cmd.SetExited(exitStatus)
Expand Down