Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

feat: use actual inline SVGs instead of svg?include imports#1017

Open
dstaley wants to merge 1 commit into
mainfrom
ds.react-button-svg-include
Open

feat: use actual inline SVGs instead of svg?include imports#1017
dstaley wants to merge 1 commit into
mainfrom
ds.react-button-svg-include

Conversation

@dstaley
Copy link
Copy Markdown
Contributor

@dstaley dstaley commented Jan 10, 2024

🎟️ Asana Task
🔍 Preview Link


Description

Describe this pull request: what is it aiming to achieve? What should someone reviewing this PR know? If this PR includes visual changes, consider including before / after screenshots, or an animated gif showing interactions.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@dstaley dstaley added the release:canary Triggers a canary release for commits to this pull request label Jan 10, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 80a6f2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 8:15pm

@github-actions
Copy link
Copy Markdown
Contributor

📦 Canary Packages Published

Latest commit: 80a6f2c

Published 1 packages

@hashicorp/react-button@6.3.2-canary-20240110201519

npm install @hashicorp/react-button@canary

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release:canary Triggers a canary release for commits to this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant