Migrate to Database v5 interface#10
Merged
Merged
Conversation
pcman312
reviewed
Oct 1, 2020
Contributor
pcman312
left a comment
There was a problem hiding this comment.
Looks good overall. Just a couple of nits, a question, and one update since hashicorp/vault#10050 was merged
pcman312
approved these changes
Oct 5, 2020
pcman312
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Converts plugin to use the Database v5 interface introduced in hashicorp/vault#9641
Modified one test to fail with no statements provided, previously, defaults were set to allow a user creation with no explicit statements/roles.
Design of Change
Converted each of the functions over to their equivalent in the new interface.
Init->InitializeCreateUser->NewUserRenewUser,SetCredentials, &RotateRootCredentials->UpdateUserRevokeUser->DeleteUserTest Output
Test Output
Contributor Checklist