Ui/pricing metrics page setup#10049
Merged
Merged
Conversation
Monkeychip
approved these changes
Sep 28, 2020
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Looks like a test failure. But this looks good. Same with the naming. Are we going to go live with this before the API endpoint is ready?
Contributor
Author
Good question, we can either merge this (and all forthcoming work) into a sidebranch until we know the API will be ready for release, or merge now and be prepared to revert later. My concern with a sidebranch is that when the ember upgrade is finished we'll have to do that process again for this new work, but hopefully since it's a small section it won't be too painful. Thoughts @Monkeychip ? |
pull Bot
pushed a commit
to NOUIY/vault
that referenced
this pull request
Oct 10, 2025
…hicorp#10049) * move request to parent * add changelog * add test * use refresh instead() Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up the Pricing Metrics UI page (currently based on mock data from the endpoint). This is the bare-bones version of this page, without date filtering or namespaces. Metrics are seen at the route
/ui/vault/metricswhile the config is at/ui/vault/metrics-config.When disabled but there is data:
Config:
TODOS: