DBPW - Revert AutoMTLS#10065
Merged
Merged
Conversation
calvn
approved these changes
Sep 30, 2020
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
Ran TestPlugin_lifecycle locally and it passed. Might want to wait for CI to finish to see if it catches any regressions though.
Contributor
Author
|
@calvn Agreed - I'm waiting for CI to be green (or at least completely unrelated) before merging. I'm also running all tests associated with the database plugin locally ( |
tvoran
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AutoMTLS somehow screwed up the tests around using v5. The tests were passing previously because of partial vendoring in #10008 and broke when the remaining vendoring came in #9794
Since a bunch of things have merged since #10008 and because we don't want to get into a strange state where vendoring is janky we're disabling AutoMTLS which appears to fix the tests.