Test Fix: test for default TTL instead of date timestamp#10070
Merged
Conversation
…o avoid 1 second off issue
chelshaw
approved these changes
Oct 1, 2020
Contributor
chelshaw
left a comment
chelshaw
left a comment
There was a problem hiding this comment.
Other than another test possibly, this change looks great!
| modalDate.slice(0, 18), | ||
| 'shows the correct expiration date and in the correct format' | ||
| ); | ||
| const modalDefaultTtl = document.querySelector('[data-test-row-value="TTL"]').innerText; |
Contributor
There was a problem hiding this comment.
Should we do one more test scenario where we don't use the default (set it to something specific) and make sure the TTL reflects that?
Contributor
Author
There was a problem hiding this comment.
Good call. Just pushed a commit that checks for when it's set at 3 minutes as well.
pull Bot
pushed a commit
to mayocream/vault
that referenced
this pull request
Oct 10, 2025
…ashicorp#9944) (hashicorp#10070) * normalize token type for ns_token auth mounts * add changelog * also check type is supported in route and add test coverage * Apply suggestion from @hellobontempo * update test coverage to expect array * update tests Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally we were testing for the date timestamp on the replication modal. The problem is there is an off chance that the timestamp could be off by 1 second. To fix this we are instead checking for the default TTL of 1800. We no longer check date formatting but are still checking for the correct default TTL, which was the core of this test in the first place.