Add a helper function for safely grabbing a keyEntry by version#10080
Merged
Conversation
briankassouf
reviewed
Oct 5, 2020
| if !ok { | ||
| return nil, errutil.UserError{Err: "no such key version"} | ||
| } | ||
| return &keyEntry, nil |
Contributor
There was a problem hiding this comment.
Can we go back to returning by value here?
Collaborator
Author
There was a problem hiding this comment.
There was some reason it didn't work, but I'll take another look.
Collaborator
Author
There was a problem hiding this comment.
Nm, works just fine. Changed.
…o safe-keyentry-fetch
briankassouf
approved these changes
Oct 7, 2020
tsaarni
pushed a commit
to Nordix/vault
that referenced
this pull request
Oct 23, 2025
…ashicorp#9944) (hashicorp#10073) (hashicorp#10080) * normalize token type for ns_token auth mounts * add changelog * also check type is supported in route and add test coverage * Apply suggestion from @hellobontempo * update test coverage to expect array * update tests Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.