Auto-Join: Configurable Scheme & Port (and add k8s provider)#10192
Merged
Conversation
ncabatoff
reviewed
Oct 20, 2020
ncabatoff
approved these changes
Oct 20, 2020
ncabatoff
reviewed
Oct 20, 2020
alexanderbez
force-pushed
the
core/auto-join-scheme-port-cfg
branch
from
a5fcbb0 to
3a58a54
Compare
ncabatoff
reviewed
Oct 20, 2020
|
|
||
| // AutoJoinScheme defines the optional URI protocol scheme for addresses | ||
| // discovered via auto-join. | ||
| AutoJoinScheme string `json:"auto_join_scheme"` |
Collaborator
There was a problem hiding this comment.
Do we want omitempty on this and the other AutoJoin fields?
Contributor
Author
There was a problem hiding this comment.
Depends. Is this configuration exposed in any responses or other client-facing calls? I'm suspicion is that it's not. @briankassouf?
Contributor
There was a problem hiding this comment.
Yeah, I don't actually think that we ever json marshal this struct, but you may want to confirm that.
Collaborator
There was a problem hiding this comment.
I was thinking about the sanitized config output, though perhaps it doesn't marshall this directly.
alexanderbez
changed the title
alexanderbez
commented
Oct 20, 2020
ncabatoff
approved these changes
Oct 23, 2020
Contributor
Author
|
1.6.x backport => #10229 |
ncabatoff
pushed a commit
that referenced
this pull request
Oct 26, 2020
pull Bot
pushed a commit
to sigtrap/vault
that referenced
this pull request
Oct 17, 2025
Synchronize all common Go module versions with enterprise. Signed-off-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retry_joinstanza used for auto-join IP discovery. Vault defaults to HTTPS/8200 when these values are not provided.