DBPW - Enables AutoMTLS for DB plugins#10220
Merged
Merged
Conversation
This also temporarily disables couchbase, elasticsearch, and mongodbatlas because the `Serve` function needs to change signatures and those plugins are vendored in from external repos, causing problems when building.
calvn
approved these changes
Oct 22, 2020
tvoran
approved these changes
Oct 22, 2020
pcman312
added a commit
that referenced
this pull request
Oct 23, 2020
This also temporarily disables couchbase, elasticsearch, and mongodbatlas because the `Serve` function needs to change signatures and those plugins are vendored in from external repos, causing problems when building.
This was referenced Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables AutoMTLS for DB plugins. The
Servefunction withinsdk/database/dbplugin/v5/plugin_server.gois also changed so it does not take in a TLS provider function. This precipitated the need to remove couchbase, elasticsearch, and mongodbatlas from Vault temporarily since they were referencing the originalServewithin their respectiveRunfunctions. They can't be modified in place because those three plugins are external repos that are pulled in as dependencies. For this PR, those three are commented out so the SDK can be updated. The next step will be to update the three external repos to use the newServefunction, followed by re-enabling them in Vault.Part 1/3: Adding AutoMTLS into the DB engine for external databases, disable couchbase, elasticsearch, and mongodbatlas
Part 2/3: Update couchbase, elasticsearch, & mongodbatlas to use new
ServefunctionPart 3/3: Re-enable couchbase, elasticsearch, & mongodbatlas & revendor into Vault
Kudos to @briankassouf for figuring out the issue with the previous attempt to use AutoMTLS: #10204