add consul service metadata#10233
Closed
Chrisss93 wants to merge 2 commits into
Closed
Conversation
|
|
Contributor
|
I realize that it has been some time since you submitted this PR, and I apologize for the delay. We would like to incorporate these changes, but there are merge conflicts that need resolving. Would you be able to resolve those so we can get this PR merged in? Thanks! |
Contributor
|
@Chrisss93 there are still some merge conflicts here - are you willing to resolve those so we can get this merged? Please let me know how you'd like to proceed. Thanks! |
Contributor
|
Hi there! I'm going to close this, since there was no response to my previous comment. If you're still interested in getting this merged, feel free to open a new pull request with the conflicts resolved! |
pull Bot
pushed a commit
to mayocream/vault
that referenced
this pull request
Oct 21, 2025
* license: update headers to IBM Corp. * `make proto` * update offset because source file changed Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extra configuration parameter "meta" in the Vault configuration's storage block to specify metadata for Consul service registration. Addresses #9121