Ui/test metrics mirage#10341
Merged
Merged
Conversation
Monkeychip
reviewed
Nov 6, 2020
Monkeychip
reviewed
Nov 6, 2020
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Nice work! There's a failing UI test, but other than that looks great!
Monkeychip
approved these changes
Nov 6, 2020
chelshaw
added a commit
that referenced
this pull request
Nov 9, 2020
chelshaw
added a commit
that referenced
this pull request
Nov 9, 2020
tsaarni
pushed a commit
to Nordix/vault
that referenced
this pull request
Nov 18, 2025
…icorp#10523) * [UI] Ember Data Migration - PKI Config Setup (hashicorp#10320) * adds api and capabilities services to pki engine * updates eslintrc to ignore rest siblings for no-unused-vars rule * adds ember-template-lint to pki engine * updates check-issuers decorator to use api service * adds constants for pki capabilities paths * updates pki configuration route to use api service and fetch capabilities * [UI] Ember Data Migration - PKI Config Generate Form (hashicorp#10322) * updates form class data object to tracked * adds isNot validator * updates tsconfig to resolve json modules * updates open-api form class to use the spec file rather than help response for form field/group generation * adds pki config generate form * [UI] Ember Data Migration - PKI Config Create (hashicorp#10331) * updates pki configure create route and component * updates pki generate csr component to use api service and form class * updates pki generate root component to use api service and form class * updates pki import bundle component to use api service * [UI] Ember Data Migration - PKI Config Generate Sub Components (hashicorp#10332) * updates pki generate toggle groups component to support form class * updates pki key parameters component to support form class * updates pki generate immediate component based on csr component changes * updates pki generate root component based on root component changes * more pki config sub component updates * updates pki issuer rotate root component to use api serivce and form * updates pki acceptance tests (hashicorp#10341) * [UI] Ember Data Migration - PKI Configuration Edit (hashicorp#10339) * adds forms for pki config acme, cluster, crl and urls * updates pki config edit worflow to use api service and forms * updates pki config details workflow to use api service (hashicorp#10340) * updates auth configure section route to pass schema key to OpenApiForm constructor Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Mirage dependency and uses it for testing the pricing metrics UI.
Up until now, all of our front end tests take advantage of real calls to vault APIs, because none of the data is expected to just live on the server. However, with this new endpoint it does expect data to accumulate over time, which is unreasonable to wait for testing.
While writing these tests I did find a legitimate bug where if the data is queried but doesn't have any data, "Invalid date" is shown:
Fixed:
