Skip to content

Remove unused http-request-xx components and associated files#10360

Merged
Monkeychip merged 2 commits into
masterfrom
ui/remove-http-request-bar-chart
Nov 10, 2020
Merged

Remove unused http-request-xx components and associated files#10360
Monkeychip merged 2 commits into
masterfrom
ui/remove-http-request-bar-chart

Conversation

@Monkeychip
Copy link
Copy Markdown
Contributor

@Monkeychip Monkeychip commented Nov 9, 2020

In the Key Metrics project --here's a reference PR --we removed the http-request table. This PR cleans up the files that are no longer being used.

Files removed:

  • http-request-bar-chart-simple (js, hbs, md, stories, test)
  • http-request-bar-chart (scss, js, hbs, md, stories, test)
  • http-request-container (js, hbs, md, stories, test)
  • http-request-table (scss, js, hbs, md, stories)
  • reference in selectable-card scss file to the class http-requests-bar-chart-simple
  • removing the import o the scss files into core.scss

@Monkeychip Monkeychip added the ui label Nov 9, 2020
@Monkeychip Monkeychip modified the milestones: 1.6.1, 1.7 Nov 9, 2020
Copy link
Copy Markdown
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Assuming all the tests pass!
R.I.P bar chart, may we meet again soon

@Monkeychip
Copy link
Copy Markdown
Contributor Author

LGTM Assuming all the tests pass!
R.I.P bar chart, may we meet again soon

I'll be bookmarking this pr for d3 reference later. Fingers crossed we do meet again.

@Monkeychip Monkeychip merged commit 0340b40 into master Nov 10, 2020
@Monkeychip Monkeychip deleted the ui/remove-http-request-bar-chart branch November 10, 2020 19:00
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants