More CL notes for 1.6.2 (#10792)#10795
Merged
Merged
Conversation
* More CL notes for 1.6.2 * Update _2021Jan26.txt * Update _2021Jan26.txt
|
This pull request is being automatically deployed with Vercel (learn more). vault – ./website🔍 Inspect: https://vercel.com/hashicorp/vault/3j32e0b8f vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/dpy7kj6x6 |
raskchanky
approved these changes
Jan 27, 2021
pull Bot
pushed a commit
to mayocream/vault
that referenced
this pull request
Nov 18, 2025
…corp#10768) (hashicorp#10870) * VAULT-40827 Remove isOldEngine property * VAULT-40826 clean up plugin links logic * Fix plugin settings logic.. * Add comments.. * Fix bug! * AAdd configEdit and configRead route * Configure tabs suggestion (hashicorp#10795) * refactor logic into one local helper * refactor to pass in metadata * update comments * fix arg typo * don't make assumptions! explicitly check whether an engine isConfigurable * pass in @isConfigured arg and add isConfigurable boolean for any engine * add integration test * add acceptance test * Use configs * Remove unused vars * Use configurableEngines * Add aftermodel hook.. * add list route nav test * Remove dropdown * Remove mount config test * Fix failign tests * Fix tests.. --------- Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com> Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> Co-authored-by: claire bontempo <cbontempo@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More CL notes for 1.6.2
Update _2021Jan26.txt
Update _2021Jan26.txt